<html>
<head><meta charset="utf-8"><title>Reviewer for bit-rotty PR · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewer.20for.20bit-rotty.20PR.html">Reviewer for bit-rotty PR</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="212963968"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewer%20for%20bit-rotty%20PR/near/212963968" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewer.20for.20bit-rotty.20PR.html#212963968">(Oct 11 2020 at 12:37)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/77808">https://github.com/rust-lang/rust/pull/77808</a> should be an easy review, but runs into merge conflicts very quickly. Can someone take a look?</p>



<a name="212980868"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewer%20for%20bit-rotty%20PR/near/212980868" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewer.20for.20bit-rotty.20PR.html#212980868">(Oct 11 2020 at 20:42)</a>:</h4>
<p>Seems reasonable to me, though I'm not a compiler reviewer.</p>



<a name="212980870"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewer%20for%20bit-rotty%20PR/near/212980870" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewer.20for.20bit-rotty.20PR.html#212980870">(Oct 11 2020 at 20:42)</a>:</h4>
<p>The new file is so close to 3000 lines, though, that it seems like it'll need splitting itself soon enough.</p>



<a name="212980879"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewer%20for%20bit-rotty%20PR/near/212980879" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewer.20for.20bit-rotty.20PR.html#212980879">(Oct 11 2020 at 20:43)</a>:</h4>
<p>yeah :/ I guess maybe it could be split into multiple impls?</p>



<a name="212980883"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewer%20for%20bit-rotty%20PR/near/212980883" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewer.20for.20bit-rotty.20PR.html#212980883">(Oct 11 2020 at 20:43)</a>:</h4>
<p>Well, it seems fine to do the split as they wrote it initially.</p>



<a name="212980886"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewer%20for%20bit-rotty%20PR/near/212980886" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewer.20for.20bit-rotty.20PR.html#212980886">(Oct 11 2020 at 20:43)</a>:</h4>
<p>Just that it won't defer the problem for long.</p>



<a name="212980926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewer%20for%20bit-rotty%20PR/near/212980926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewer.20for.20bit-rotty.20PR.html#212980926">(Oct 11 2020 at 20:44)</a>:</h4>
<p>(not my PR but I agree)</p>



<a name="212980944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewer%20for%20bit-rotty%20PR/near/212980944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewer.20for.20bit-rotty.20PR.html#212980944">(Oct 11 2020 at 20:45)</a>:</h4>
<p>(Zulip's UI for editing is painful sometimes.)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>